Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change links to reflect changes on queryapi #1584

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

roshaans
Copy link
Contributor

Do not merge yet

Copy link

render bot commented Nov 14, 2023

roshaans added a commit to near/queryapi that referenced this pull request Nov 16, 2023
This PR addresses a few painpoints of logging and QueryAPI Indexer
development.

1. Logs can now be seen through the QueryAPI editor window via a `Show
Logs` button.
- No need to switch between `Indexer Status` & `Editor` window anymore
saving time and frustration with the editor taking a few seconds to
load.
- Enables more powerful integrations with the editor for future PRs
(e.g: adding blocks to debug directly from the indexer Logs table)

2. Logs are easier to digest now and search now. 
- Logs are grouped by `block_height` so now the user sees all the
messages belonging to a block's execution together.
- Additionally the user can use the `search` functionality to search for
any block_height where the function was executed to view its log in
entirety.
             - Logs have relative dates now e.g (4 mins ago...)
- BlockHeights can be clicked on to take you to the explorer link
             
3. Simplifying QueryAPI links.
- There is no need for `&view=status/editor-window` to be passed in
anymore.
- As long as `selectedIndexerPath` is defined, the user is sent to the
editor window. If `&view=status` is passed the user is redirected to the
indexer logs page within the editor window.
- Note: I have a PR on `queryapi/docs` to reflect these changes:
near/docs#1584
  
Notes: Instead of using GraphQL to fetch logs, we are using a feature of
Hasura which `restifies` your graphql queries.
You can find details here:
https://near-queryapi.api.pagoda.co/console/api/rest/list
  
- The Old Indexer Status Widget should still be avalaible if needed via
the following link:
https://near.org/dataplatform.near/widget/QueryApi.IndexerStatus?accountId=dataplatform.near&indexer_name=social_feed
  
Other small updates
- If a invalid indexer path is chosen, the editor will show an error
- QueryAPI is avalaible for users in read only mode even if they are not
logged in on near.org

### This PR does not add WS support. This will be done in a future PR. 
  

![image](https://github.com/near/queryapi/assets/25015977/0e94ede2-6cca-41ae-9dd4-827ff388ba48)

![image](https://github.com/near/queryapi/assets/25015977/01e655cb-786d-4913-9b09-e00014037863)
![queryapi logs
testing](https://github.com/near/queryapi/assets/25015977/c66d980c-0988-492e-b225-46371ff7572e)
@bucanero
Copy link
Collaborator

hi @roshaans , can I merge this PR now?

@roshaans
Copy link
Contributor Author

hi @roshaans , can I merge this PR now?

Let's wait till this PR in flight is merged: near/queryapi#414

@bucanero bucanero marked this pull request as ready for review November 28, 2023 13:03
@bucanero bucanero merged commit 80bc732 into master Nov 28, 2023
2 of 3 checks passed
@bucanero bucanero deleted the change-queryapi-links branch November 28, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped 🚀
Development

Successfully merging this pull request may close these issues.

2 participants