chore: cleanup jsonrpc client in integration tests #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailisp
reviewed
Sep 4, 2024
| })) | ||
| .max_gas() | ||
| .deposit(NearToken::from_yoctonear(1)) | ||
| .transact_async() |
There was a problem hiding this comment.
nice enhancement, i've seen concurrent tests fail due to invalid nonce
There was a problem hiding this comment.
yeah hopefully this resolves that a bit. It won't retry though since near-fetch requires explicit .retry_expoential(...)
volovyks
reviewed
Sep 4, 2024
ChaoticTempest
force-pushed
the
phuong/chore/cleanup-jsonrpc-client
branch
from
0a83e67
to
a74c620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to use jsonrpc-client separately anymore since
near_fetch::Clientis quite feature rich now and can directly do everything more cleanly there