fix: changes based on review comments

near · Jun 2, 2023 · f766671 · f766671
1 parent 8731572
commit f766671
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/packages/light-client/src/block.ts b/packages/light-client/src/block.ts
@@ -139,10 +139,7 @@ export function validateLightClientBlock({
 function hashBlockProducers(bps: ValidatorStakeView[]): Buffer {
     const borshBps: BorshValidatorStakeView[] = bps.map((bp) => {
         if (bp.validator_stake_struct_version) {
-            const version = parseInt(
-                bp.validator_stake_struct_version.slice(1)
-            );
-            if (version !== 1) {
+            if (bp.validator_stake_struct_version !== 'V1') {
                 throw new Error(
                     'Only version 1 of the validator stake struct is supported'
                 );

diff --git a/packages/light-client/src/borsh.ts b/packages/light-client/src/borsh.ts
@@ -170,4 +170,4 @@ export const SCHEMA = new Map<Class, any>([
             ],
         },
     ],
-]);
+]);
diff --git a/packages/types/src/assignable.ts b/packages/types/src/assignable.ts
@@ -14,6 +14,9 @@ export abstract class Enum {
             throw new Error('Enum can only take single value');
         }
         Object.keys(properties).map((key: string) => {
+            if (key === 'enum') {
+                throw new Error('Enum can not take key named enum');
+            }
             (this as any)[key] = properties[key];
             this.enum = key;
         });