Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote EXPERIMENTAL_light_client_proof to non-experimental #347

Merged
merged 3 commits into from
Jun 23, 2020

Conversation

evgenykuzyakov
Copy link
Contributor

Recent change in nearcore promoted the RPC which broke nearlib-tests: near/nearcore#2859

@vgrichina
Copy link
Contributor

Recent change in nearcore promoted the RPC which broke nearlib-tests: near/nearcore#2859

@evgenykuzyakov why not keep experimental_ as alias as well? This doesn't look like good upgradability plan.

@evgenykuzyakov
Copy link
Contributor Author

That's what I suggested on the attached nearcore change. I also didn't realize that nearlib CI runs on multiple version which requires proper upgradeability. Let's keep the actual RPC endpoint to be EXPERIMENTAL_, but the nearlib method can be without experimental_ prefix.

@vgrichina
Copy link
Contributor

I also didn't realize that nearlib CI runs on multiple version which requires proper upgradeability.

that is done exactly to prevent stuff like this where RPC method just removed abruptly ;)

Let's keep the actual RPC endpoint to be EXPERIMENTAL_, but the nearlib method can be without experimental_ prefix.

Let's also keep old method as alias, but use depd to show deprecation warning (see

const deprecate = depd('JsonRpcProvider.block(blockId)');
for example).

Note like it's critical, but makes sense to establish proper deprecation process.

@vgrichina vgrichina merged commit 3a85970 into master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants