feat: add mainnet config #322
Conversation
config.js
Outdated
| return { | ||
| networkId: 'default', | ||
| networkId: 'mainnet', | ||
| nodeUrl: 'https://rpc.nearprotocol.com', | ||
| contractName: CONTRACT_NAME, | ||
| walletUrl: 'https://wallet.nearprotocol.com', |
There was a problem hiding this comment.
this would be a problem given these are URLs for testnet wallet, helper and RPC right now.
I think we might need to do update in steps:
- update both
productionanddevelopmentto point to testnet URLs. This will need to happen not only in near-shell, but in all examples as well. - after 1) we need to disable
wallet.nearprotocol.com,helper.nearprotocol.comandrpc.nearprotocol.com(get everybody who tries hitting them error with instructions to switch to testnet). For Wallet we'll need some key migration strategy. - after enough time passed for 2) to affect anybody active enough (and when wallet is ready for mainnet) – we can bring up these endpoints and update
productionto meanmainnet.
There was a problem hiding this comment.
but this means that near-shell will be hard to use for mainnet for a while
There was a problem hiding this comment.
The plan on the wallet side is to have a landing page for mainnet to inform people that mainnet wallet is not ready yet.
There was a problem hiding this comment.
but this means that near-shell will be hard to use for mainnet for a while
@bowenwang1996 I think we should add explicit mainnet and testnet as part of (1).
The plan on the wallet side is to have a landing page for mainnet to inform people that mainnet wallet is not ready yet.
this is not enough if we don't want people to lose their testnet accounts at wallet.nearprotocol.com (though if we put on landing page and nobody complains – maybe we shouldn't care :D).
There was a problem hiding this comment.
I agree, let's start with:
- rpc.mainnet.nearprotocol.com
- wallet.mainnet.nearprotocol.com
While we are migrating.
Migrating default is indeed important. Let's may be add temporary message that when you call it first time with default asks - if you are using mainnet or testnet? If they say testnet it renames default into testnet.
Ideally we should stop using NODE_ENV as it's very weird. And instead adopt something like near network testnet/mainnet. Then if network is not selected at the start, it can list all networks and ask to select one.
@bowenwang1996 I think for first 1-2 weeks it's fine if to use MainNet ppl need to set it up. It's going to be mostly us and few initial developers.
There was a problem hiding this comment.
I have changed the urls to have mainnet in them. What should I do about default?
Add mainnet config for production environment. Also change testnet config urls.