This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
Metrics events all #327
Merged
Metrics events all #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
janedegtiareva
commented
Apr 24, 2020
•
janedegtiareva
commented
mikedotexe
approved these changes
Apr 24, 2020
| console.log(`Staking ${options.amount} (${utils.format.parseNearAmount(options.amount)}) on ${options.accountId} with public key = ${options.stakingKey}.`); | ||
| const near = await connect(options); | ||
| const account = await near.account(options.accountId); | ||
| const result = await account.stake(options.stakingKey, utils.format.parseNearAmount(options.amount)); | ||
| console.log(inspectResponse(result)); | ||
| await eventtracking.track(eventtracking.EVENT_ID_STAKE_END, { node: options.nodeUrl, success: true }); |
There was a problem hiding this comment.
Looks great. We don't have the amount on the success here, but that's not a hard requirement imo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.