Disable callback url capture for windows as a temp workaround #341

janedegtiareva · 2020-04-30T21:54:07Z

This needs a deeper dive to fix properly.

janedegtiareva · 2020-04-30T22:00:36Z

Tested on windows and through cloud VM terminal login flow (have to use the fallback).

amgando · 2020-05-01T04:23:45Z

works fine on macOS

amgando · 2020-05-01T04:26:40Z

index.js

        const getAccountFromConsole = async () => {
            return await new Promise((resolve) => {
                rl.question(
                    chalk`Please authorize at least one account at the URL above.\n\n` +
                    chalk`Which account did you authorize for use with NEAR Shell?\n` +
-                    chalk`{bold Enter it here (if not redirected automatically):}\n`, async (accountId) => {
+                    chalk`{bold Enter it here${redirectAutomaticallyHint}:}\n`, async (accountId) => {


better to add whitespace after the e in "here"

otherwise it looks cramped

amgando · 2020-05-01T04:29:40Z

@AnaisUrlichs can you try this on linux?

git clone git@github.com:near/near-shell.git
cd near-shell
yarn
./bin/near login

does it:

open a web browser to NEAR Wallet?
move through the wallet flow until the page "you are logged in. close this window"?
show something like this in your console when you switch back?

amgando · 2020-05-01T08:19:18Z

@janedegtiareva CI tests are bc config.js doesn't have a ci-staging key. see #308 for possible fix

janedegtiareva added 2 commits April 30, 2020 14:53

Disable callback url capture for windows as a temp workaround

b8fc0ad

This needs a deeper dive to fix properly.

Update the comments for the windows use case

344dcfa

amgando reviewed May 1, 2020

View reviewed changes

amgando added 2 commits May 1, 2020 07:34

resolve minor linter issues

581e908

add space for message readability

c38f710

amgando mentioned this pull request May 1, 2020

Replace ci-staging with ci-betanet #308

Merged

janedegtiareva merged commit 2bb9f36 into master May 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable callback url capture for windows as a temp workaround #341

Disable callback url capture for windows as a temp workaround #341

janedegtiareva commented Apr 30, 2020

janedegtiareva commented Apr 30, 2020

amgando commented May 1, 2020

amgando May 1, 2020

amgando May 1, 2020

amgando commented May 1, 2020 •

edited

Loading

amgando commented May 1, 2020

Disable callback url capture for windows as a temp workaround #341

Disable callback url capture for windows as a temp workaround #341

Conversation

janedegtiareva commented Apr 30, 2020

janedegtiareva commented Apr 30, 2020

amgando commented May 1, 2020

amgando May 1, 2020

Choose a reason for hiding this comment

amgando May 1, 2020

Choose a reason for hiding this comment

amgando commented May 1, 2020 • edited Loading

amgando commented May 1, 2020

amgando commented May 1, 2020 •

edited

Loading