This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
address windows, mac, linux behavior w/ callback and auto-open Wallet #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikedotexe
requested review from
vgrichina and
janedegtiareva
and removed request for
vgrichina
janedegtiareva
approved these changes
May 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #358
See the reproduction steps there.
Basically we cannot trust any OS other than Mac to have the callback and auto-open links working consistently.
It was a nice cherry-on-top, but we are causing errant behavior for our users and need to stop it. Unless you're using a Mac.