Use temporary instead of permanent redirect during login #363
Conversation
When using 301 redirect it gets cached in Chrome and next time URL is opened server isn't even hit.
vgrichina
force-pushed
the
fix-gitpod-login
branch
from
1a5754f
to
90ffdcb
Compare
|
Wow, why does 302 behave so differently? 😵 |
| } | ||
| } catch (error) { | ||
| // console.error("Failed to find suitable port.", error.message) | ||
| // TODO: Is it? Try triggering error | ||
| // silent error is better here | ||
| } | ||
|
|
||
| // if we found a suitable URL, attempt to use it | ||
| if (tempUrl) { |
There was a problem hiding this comment.
we can move all this logic into the above try catch under if (!isWin) but I'm fine with it
There was a problem hiding this comment.
@mikedotexe I just reverted previous change in this part of code.
it kinda makes sense, one is temporary redirect, another is permanent redirect (so makes sense to avoid querying URL again). |
|
I still don't understand why this works on OS X, then, but glad this is a solution. |
hmm, this was already part of this PR |
Maybe it just worked in Safari? Safari doesn't cache permanent redirect it seems. |
When using 301 redirect it gets cached in Chrome and next time URL is opened server isn't even hit.
Fixes #358