This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
Ask for event tracking opt-in only in interactive commands #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now this includes: - near login - near dev-deploy
vgrichina
force-pushed
the
fix-metrics-opt-in
branch
from
13548a9
to
f464166
Compare
janedegtiareva
approved these changes
May 20, 2020
| @@ -9,47 +9,14 @@ const settings = require('./settings'); | |||
| const TRACKING_ENABLED_KEY = 'trackingEnabled'; | |||
| const TRACKING_SESSION_ID_KEY = 'trackingSessionId'; | |||
|
|
|||
| const shouldOptInByDefault = () => { | |||
| const isGitPod = !!process.env.GITPOD_WORKSPACE_URL; | |||
There was a problem hiding this comment.
Can we do just process.env.GITPOD_WORKSPACE_URL?
There was a problem hiding this comment.
in this case we can, however it's pretty commonly used for explicit cast to boolean: https://stackoverflow.com/questions/784929/what-is-the-not-not-operator-in-javascript
main difference is if somebody downstream uses return value outside of logical operation (e.g. shouldOptInByDefault() === true or shouldOptInByDefault().toString() – this can fail in unexpected way if not coerced into boolean here
I'd prefer to keep it as is because we return value outside of function (and it is reasonable for caller to expect it is boolean)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now this includes:
Related to #306
This change had to be done to make sure that opt-in flow doesn't interfere with usage in scripts.