This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
add delete-key command to delete access key #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
approved these changes
May 21, 2020
|
@mikedotexe why is this flag |
|
@bowenwang1996 going to wait for tests to pass for posterity but then I'll merge and check with Vlad about cutting a release. If I don't hear back from him I'll cut one |
you mean as opposed to just UPDATE: good point, Bowen. pushed fix so it's like that. |
vgrichina
reviewed
May 21, 2020
index.js
Outdated
| @@ -199,6 +199,16 @@ exports.sendMoney = async function (options) { | |||
| await eventtracking.track(eventtracking.EVENT_ID_SEND_TOKENS_END, { node: options.nodeUrl, success: true }); | |||
| }; | |||
|
|
|||
| exports.deleteAccessKey = async function (options) { | |||
There was a problem hiding this comment.
nit: I'd prefer we add new commands as separate self-contained files (i.e. in commands/ folder). We should extract existing commands too eventually.
There was a problem hiding this comment.
okay, pushed up that change, Vlad
vgrichina
reviewed
May 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete's an access key.
Pull down branch and you can use this command
Command:
./bin/near delete-key 2rLDDvyk8wdpq4TZ3k2xmCxhykq431eNKQ7Mfg31nT4q --accountId mike.testnetThe access key can be copied from Wallet. Tested on full access and authorized apps keys.