feat: new login modal #1330
Merged
feat: new login modal #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gagdiez
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the modal has always started with "login with email", which was very nice when we were a social network, but might not be so comfortable for web3 devs.
More importantly, right now to discover that you can login with Ethereum wallets, you need to make 3 clicks: "login -> login again -> click on the wallet"
I created a wrapper over FastAuth, so it now shows as "login with email" on the wallet selector, and removed the right panel on the selector since it had too much web3 jargon.
On a future update it would be nice to bring back the error messages that the right panel was showing, maybe at the bottom of the modal