Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

feat: New Display information and statistic on dashboard without chart #466

Closed
wants to merge 17 commits into from

Conversation

icerove
Copy link
Contributor

@icerove icerove commented Nov 4, 2020

partially addressed #350
2. fix the node and block card
3. fix the transaction card without chart

@render
Copy link

render bot commented Nov 4, 2020

@frol
Copy link
Collaborator

frol commented Nov 10, 2020

@icerove given the plan @corwinharrell suggests:

We shouldn't ship any changes from the dashboard refresh until we feel like confident that the design changes applied site-wide are consistent, and that it doesn't feel like the dashboard is too divergent from the other views.

I suggest we land all the changes to the backend in a separate PR, so we can land it first, so we have the Render PR URL working fine. Could you do that?

@frol
Copy link
Collaborator

frol commented Nov 10, 2020

On the other hand, in that case we will be required to make sure we don't break the currently deployed frontend (the stats should be additive instead of replacing one with another)

@frol frol changed the title Refactor/frontend feat: Display information and statistic on dashboard Nov 11, 2020
@icerove icerove requested a review from frol November 12, 2020 18:42
@icerove icerove marked this pull request as ready for review November 12, 2020 18:42
@icerove
Copy link
Contributor Author

icerove commented Nov 12, 2020

remember to pull the latest change I made. @frol

@frol
Copy link
Collaborator

frol commented Nov 13, 2020

@icerove I have deployed the backend and frontend to new instances on Render, so we can test it online with @corwinharrell and anyone willing to give it a try., but it currently fails due to TypeScript errors. Please, fix those and you should be able to see the deployed version on https://near-explorer-frontend-redesign.onrender.com/

@frol
Copy link
Collaborator

frol commented Nov 16, 2020

The tests fail due to:

ERROR in /near-explorer/frontend/src/components/dashboard/DashboardHeader.tsx(88,33):
Property 'totalTransactions' does not exist on type '{ finalTimestamp: number; latestBlockHeight: number; latestGasPrice: string; numberOfLastMinuteBlocks: number; transactionCountArray: never[]; lastDayTxCount: number; last2DayTxCount: number; }'.

Please, address that

@frol frol marked this pull request as draft December 4, 2020 22:31
@icerove icerove changed the title feat: Display information and statistic on dashboard feat: New Display information and statistic on dashboard without chart Dec 9, 2020
@icerove icerove closed this Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants