Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

feat(frontend): Migrate Explorer to the Indexer for Explorer #477

Merged
merged 25 commits into from
Dec 10, 2020

Conversation

icerove
Copy link
Contributor

@icerove icerove commented Nov 13, 2020

migration plan frontend part.
finish #450 2 3 and 4 part

@render
Copy link

render bot commented Nov 13, 2020

@frol
Copy link
Collaborator

frol commented Nov 16, 2020

The tests fail with:

src/components/accounts/AccountRow.tsx(2,1): error TS6133: 'moment' is declared but its value is never read.
src/components/blocks/__tests__/BlockDetails.test.tsx(11,13): error TS2322: Type '{ transactionsCount: number; timestamp: number; hash: string; prevHash: string; height: number; gasPrice: string; gasUsed: string; isFinal: true; }' is not assignable to type 'BlockInfo'.
  Object literal may only specify known properties, but 'transactionsCount' does not exist in type 'BlockInfo'. Did you mean to write 'transactions_count'?
src/components/blocks/__tests__/BlocksRow.test.tsx(11,13): error TS2769: No overload matches this call.
  Overload 1 of 2, '(props: Readonly<Props>): default', gave the following error.
    Type '{ transactionsCount: number; timestamp: number; hash: string; prevHash: string; height: number; gasPrice: string; isFinal: false; }' is not assignable to type 'BlockInfo'.
      Object literal may only specify known properties, but 'transactionsCount' does not exist in type 'BlockInfo'. Did you mean to write 'transactions_count'?
  Overload 2 of 2, '(props: Props, context?: any): default', gave the following error.
    Type '{ transactionsCount: number; timestamp: number; hash: string; prevHash: string; height: number; gasPrice: string; isFinal: false; }' is not assignable to type 'BlockInfo'.
      Object literal may only specify known properties, but 'transactionsCount' does not exist in type 'BlockInfo'. Did you mean to write 'transactions_count'?
src/components/dashboard/DashboardBlocksBlock.tsx(38,34): error TS2551: Property 'transactionsCount' does not exist on type 'BlockInfo'. Did you mean 'transactions_count'?
src/components/dashboard/__tests__/BlockBlock.test.tsx(11,13): error TS2769: No overload matches this call.
  Overload 1 of 2, '(props: Readonly<Props>): default', gave the following error.
    Type '{ transactionsCount: number; timestamp: number; hash: string; prevHash: string; height: number; gasPrice: string; isFinal: true; }' is not assignable to type 'BlockInfo'.
      Object literal may only specify known properties, but 'transactionsCount' does not exist in type 'BlockInfo'. Did you mean to write 'transactions_count'?
  Overload 2 of 2, '(props: Props, context?: any): default', gave the following error.
    Type '{ transactionsCount: number; timestamp: number; hash: string; prevHash: string; height: number; gasPrice: string; isFinal: true; }' is not assignable to type 'BlockInfo'.
      Object literal may only specify known properties, but 'transactionsCount' does not exist in type 'BlockInfo'. Did you mean to write 'transactions_count'?

Please, address that

frontend/src/components/utils/Timer.jsx Outdated Show resolved Hide resolved
frontend/src/libraries/explorer-wamp/blocks.ts Outdated Show resolved Hide resolved
frontend/src/libraries/explorer-wamp/blocks.ts Outdated Show resolved Hide resolved
frontend/src/libraries/explorer-wamp/blocks.ts Outdated Show resolved Hide resolved
frontend/src/libraries/explorer-wamp/blocks.ts Outdated Show resolved Hide resolved
frontend/src/libraries/explorer-wamp/blocks.ts Outdated Show resolved Hide resolved
frontend/src/libraries/explorer-wamp/accounts.ts Outdated Show resolved Hide resolved
@icerove icerove marked this pull request as ready for review November 19, 2020 22:02
@icerove icerove requested a review from frol November 19, 2020 22:05
@icerove
Copy link
Contributor Author

icerove commented Nov 19, 2020

fix the query method but wait for your new design for call current database or indexer. @frol

@icerove icerove closed this Nov 19, 2020
@icerove icerove reopened this Nov 19, 2020
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@icerove This is massive! Thanks for this tremendous work! I will work on the new design later today

frontend/src/components/utils/ListHandler.tsx Outdated Show resolved Hide resolved
frontend/src/components/utils/Timer.jsx Outdated Show resolved Hide resolved
frontend/src/components/utils/Timer.jsx Outdated Show resolved Hide resolved
@render
Copy link

render bot commented Nov 24, 2020

@icerove icerove changed the title Factor/frontend migrate indexer query Factor/migration indexer query on frontend Nov 25, 2020
@icerove icerove changed the title Factor/migration indexer query on frontend Factor/migration indexer query on frontend api Nov 25, 2020
@frol frol changed the title Factor/migration indexer query on frontend api feat(frontend): Migrate Explorer to the Indexer for Explorer Dec 4, 2020
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked by #499

@frol frol merged commit 3783a51 into master Dec 10, 2020
@frol frol deleted the factor/frontend-migrate-indexer-query branch December 10, 2020 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants