-
Notifications
You must be signed in to change notification settings - Fork 56
feat(frontend): New design for the header and the footer and background #483
Conversation
Your Render PR Server URL is https://near-explorer-frontend-pr-483.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-bupigmf93em3mi7lsfs0. |
@jakestutzman can you please provide @icerove with the most up to date NEARkat illustration for use in the explorer footer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues on Desktop
- Search bar in nav is not centered
- Nav items are not vertically aligned
- Logo should not scale dynamically. It should be one size for desktop, and then a smaller size for tablet/mobile
- There should be some padding between the icons and titles for each nav item.
- Each network should be represented by a different color
- "ChainInfo" is an abbreviation. It is also two words, not one. The original designs use the words "Explore", as this was a suggestion from internal team members. If you have received feedback that this is not an effective title, please share the feedback so we can determine a better alternative.
- The hover and active states for the dropdown menus in the nav are not consistent with the designs
- Styles for the search bar in the navigation are not consistent with the design. (hover/focus states in particular)
Issues on Mobile
- Logo and network selector are not left and right aligned.
- Primary navigation is not nested within a Menu, but is instead placed under the search bar, which is inconsistent with the designs.
@icerove it seems that most of these issues could be avoided if the implementation would more closely adhere to the designs provided. Could you articulate why there are so many things here that still need to be addressed? What resources or details have you felt are missing in order to be able to accurately implement the designs that were proposed for these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frol
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish I could just merge it, but I have to send another changes request 😖
-
the border does not match the design
-
the border shifts the input a few pixels on hover and focus and also does not match the design
-
when you click on the Search button, it goes dark green. @corwinharrell what should be the background color for the pressed button?
@icerove please, pair up with @corwinharrell to iterate faster.
@icerove Hints about the borders styling:
|
@icerove I've gone ahead and styled a version on codepen if you'd like to use it as reference for how this should be implemented. If you'd like me to go ahead and do this for the search input inside of the header as well, just let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still issues with the implementation of the new inputs.
- The borders and border radii are not consistent and aligned, which results in gaps between the inputs and border at the corners. This is most visible in the focused state:
- The border widths are not consistent. The button has narrower borders than the input.
- In addition, the search input nested in the header also has a different background color than the rest of the input. It's very slight but its there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partially address #350
New design for the header and the footer and background with font change
See more details about the design along with the Figma: #350 (comment)