Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

feat: Roll back the detailed balances on Explorer in favor of Wallet Profile link #494

Merged
merged 11 commits into from
Dec 8, 2020

Conversation

khorolets
Copy link
Member

Closes #464

We were talking through the issue with @frol and ended up removing a lot of cells in the table (FYI @icerove)

@khorolets khorolets requested a review from frol December 4, 2020 15:30
@khorolets khorolets requested a review from icerove as a code owner December 4, 2020 15:30
@render
Copy link

render bot commented Dec 4, 2020

@icerove
Copy link
Contributor

icerove commented Dec 4, 2020

great work! @khorolets
Could you please give marker on checklist to issue #464 ?

@khorolets
Copy link
Member Author

Could you please give marker on checklist to issue #496 ?

Sorry, I didn't get it about #496, can't find it. Did you want me to check checkboxes in original issue related to this PR?

@frol frol force-pushed the feat/wallet-profile-link branch from 86192f3 to 435b817 Compare December 4, 2020 19:05
@frol
Copy link
Collaborator

frol commented Dec 4, 2020

@corwinharrell @kcole16 @ilblackdragon Can you review the end result of Explorer hiding all the balances behind a link to the balances on the Wallet profile page?

With lockup account:

image

Without lockup account:

image

@frol frol merged commit ba85186 into master Dec 8, 2020
@frol frol deleted the feat/wallet-profile-link branch December 8, 2020 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roll back the detailed balances on Explorer in favor of Wallet Profile link
3 participants