-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flag on account_changes and fungible_token_events #349
Add feature flag on account_changes and fungible_token_events #349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thank you!
Could you please add the comment to readme about this, with the instruction how to enable this functionality?
We will add the link to the announcement later when we post it, but anyway we need to say at least 1 sentence here what's going on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! Although, I don't like the naming you've chosen. How about making it a bit shorter:
ft_events
account_changes
I propose dropping the load_
stuff as I haven't seen such naming in Rust features. @telezhnaya what do you think? I don't insist.
I don't have the strong opinion about the naming, we can go with any option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major:
If we want to deploy this to production (we really want to), we need to rewrite start-from-interruption
logic as well
The easiest way is to copy-paste the solution from microindexers: https://github.com/near/near-microindexers/blob/main/indexer-opts/src/lib.rs#L79
Thanks @telezhnaya and @khorolets , suggestions implemented |
0af0523
to
0b2e007
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run cargo fmt & cargo clippy
Closes #346