feat: add new param contract_bytes_base64 with type Option<Base64VecU8>
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frol
reviewed
Jun 4, 2023
hanakannzashi
changed the title
Vec<u8> with Base64VecU8 for contract_bytesBase64VecU8 for contract_bytes_base64
hanakannzashi
changed the title
Base64VecU8 for contract_bytes_base64contract_bytes_base64 as Base64VecU8
hanakannzashi
changed the title
contract_bytes_base64 as Base64VecU8 contract_bytes_base64 with type Base64VecU8
hanakannzashi
changed the title
contract_bytes_base64 with type Base64VecU8contract_bytes_base64 with type Option<Base64VecU8>
frol
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Ouch, this fall through the cracks. This change looks good to me.
@BenKurrek It seems you were the last pushing the changes to near-linkdrop to production. Do you know how to do it? Can you own/execute this process?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vec<u8>use almost 4 times gas compared withBase64VecU8, I think we should supportBase64VecU8to make contract method more useful.Gas Test
Test Code
I call these two contract methods and put contract code itself as args. Code length is 91774 bytes.
Test Result
Test Base64VecU8
Test Vec<u8>