fix: method naming conflicts

[osalkanovic]

Issue: #121

Here is working example how to prevent same functions naming as c functions.
I tried to move functions to helper, but unsuccessfully to import helper inside babel transformer, if someone can assist it would be good :))

[ailisp]

This validating pattern is cool!

[ailisp]

There are more functions to filter out, basically every C function that's included in builder.c, such as strncpy, so this is quite challenging to figure out all C function names. I wonder whether one these directions can be easier:

• when confliction happens, can we collect the C compiler's error/warning and indicate the user to rename the contract method
• can we iterate contract method names like you did, then for any name confliction, use some C code-transformation / compiler tool to rename C functions to some random names. For example, a developer can write a contract method named strncpy (:joy:), and we let the tool to rename original C strncpy (not user contract method name) to ___strncpy

[osalkanovic]

Wooow, yes. Why not, I will update PR

[volovyks]

The reason why you can not import these functions from utils is that Babel not allowing imports without .js file extension.
https://stackoverflow.com/questions/67996772/babel-not-allowing-imports-without-js-file-extension

You are importing it from ../utils, but Babel expects ../unils.js from /lib folder. You can try to apply the suggested solution, but it is not a big deal.

[ailisp]

@osalkanovic Looks like a yarn build to update the built artifacts and commit again is required to pass CI

[osalkanovic]

@ailisp can you re-run CI?

[osalkanovic]

@ailisp first step is resolved
output from groupCFunctions is https://gist.github.com/osalkanovic/062d308544159747950a6e4abf074c02

Now we have coordinates where function start in builder.c so we can easily include __ in function name :D

I have to also found coordinates for regex match functions :D
I will update PR with step 2 in next days :)

cc @volovyks can you assist with moving functions to utils?

[osalkanovic]

CI should fail because I have c function in smart contract

[ailisp]

@osalkanovic Seems that your collectCFunction/groupCFunction implemented a great algorithm that parsed all c function used in builder.c! However it doesn't collect the names in #include files. The C programming language is quite low level, there's no namespace or module concept, the #Include is equivalent to litterally copy-paste such file in place. So the function defines in #include (unless static ones, which are file-local names), will also conflict.

I suggest to look for some existing unix tool that recursively process C includes, for example ctags might work. The good news about the include files are they are almost fixed and we almost never change them, so a one time figure out the reserved function names from include files is good enough. For builder.c it can be changed in future near-sdk-js and your automatic groupCFunction is nice!

[volovyks]

@ailisp first step is resolved output from groupCFunctions is https://gist.github.com/osalkanovic/062d308544159747950a6e4abf074c02

Now we have coordinates where function start in builder.c so we can easily include __ in function name :D

I have to also found coordinates for regex match functions :D I will update PR with step 2 in next days :)

cc @volovyks can you assist with moving functions to utils?

We can move functions later. That is a separate issue.

@osalkanovic Can we continue with this PR? We are happy to help you if you are stuck with something.
It's an important feature and the code is getting outdated...

[ailisp]

Fixed in #346 . @osalkanovic Appreciate your contributions to near-sdk-js! We are now accepting proposals and give fundings to improve NEAR developer tools, including JS SDK. If you have an idea about near-sdk-js, create an Idea post labeled with near-sdk-js and reply to existing ideas with Solution post with your proposal and financial ask. We'll discuss them on a regular basis and fund proposals that pass the vote in our work group. Then you can start work on it with funding.

The place to submit idea / solution: https://devgovgigs.near.social