Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exports refactored #313

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Exports refactored #313

merged 2 commits into from
Dec 2, 2022

Conversation

volovyks
Copy link
Collaborator

@volovyks volovyks commented Dec 1, 2022

Let's follow this standard for exported functions and primitives. The file where it's defined is the only source of truth to check if it's exported. In case we need internal utils or something similar, they should be named accordingly and not be exported at all.

@volovyks volovyks marked this pull request as ready for review December 1, 2022 17:53
@volovyks volovyks requested a review from ailisp as a code owner December 1, 2022 17:53
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ailisp ailisp merged commit 8be90ed into develop Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants