-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit nft_resolve_transfer args #568
Comments
What we probably want here is a Set (probably I had a quick look and still don't understand the use of storing an integer value for each one. I'll dig into this more tomorrow. (seems like approval ids are currently required to be unique per token, not quite sure why though) |
dug slightly more into this, but it's clear there needs to be discussion around this because I need more context around what the flow is intended to be, and the fact that this is quite a breaking change so if the API is changed we need to be careful. |
Resolved in #1019 |
According to the standard:
https://nomicon.io/Standards/NonFungibleToken/Core.html#nft-interface
nft_resolve_transfer
has an argumentapproved_account_ids
that is supposed to bestring[]
but I see there's a HashMap here. There's also a place where that field callsapprovals
, which should be fixed.It seems like we don't need to pass the entire HashMap and can stick to the standard and just send a Vec instead.
This is one of those tickets where I noticed it while I'm in the middle of something, so don't have more info other than this at the moment.
The text was updated successfully, but these errors were encountered: