You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are numerous things that could/should be fixed when making state-breaking changes, so worth to batch and trying to do everything at once before asking anyone to migrate. This is not a final list, just going to start accumulating and indexing other issues:
Alternatively, could change/implement a new ordered map that stores extra data to be able to paginate more efficiently, but ordering isn't part of the NFT spec
There are numerous things that could/should be fixed when making state-breaking changes, so worth to batch and trying to do everything at once before asking anyone to migrate. This is not a final list, just going to start accumulating and indexing other issues:
no_std
and optimize size Implement no_std support for SDK #443 (somewhat optional, this isn't a state-breaking change, but better to do before)TreeMap
-- it's incredibly unscalable for iterating through pagination nft_tokens return exceed gas limit error if starting index is high enough #800owner_by_id
updated from TreeMap to UnorderedMap #8104.0
to be splitting unused gas evenly, but the static gas cannot be removed without being breaking and causes issues. Dynamic ft_transfer_calls in FT standard implementation #619 NFT contract standard: The hardcodedGAS_FOR_FT_TRANSFER_CALL
andGAS_FOR_RESOLVE_TRANSFER
doesn't work well sometimes #559NonFungibleTokenApprovalReceiver::nft_on_approve
return type #1053tokens_per_owner
? #677 (perhaps worth changing the hash to be only the first 20 bytes to minimize costs?)nft_resolve_transfer
does not match NEP (approved_account_ids
!=approvals
) #967The text was updated successfully, but these errors were encountered: