owner_by_id updated from TreeMap to UnorderedMap
#810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulate_mass_mint` test introduced
zavodil
changed the title
owner_by_id updated from TreeMap to Unordered mapowner_by_id updated from TreeMap to UnorderedMap
austinabell
suggested changes
May 9, 2022
| @@ -107,7 +107,7 @@ impl NonFungibleToken { | |||
| let mut this = Self { | |||
| owner_id, | |||
| extra_storage_in_bytes_per_token: 0, | |||
| owner_by_id: TreeMap::new(owner_by_id_prefix), | |||
| owner_by_id: UnorderedMap::new(owner_by_id_prefix), | |||
There was a problem hiding this comment.
We can't just change this because it is state-breaking and will break for anyone trying to update their NFT version.
If you need this change, you probably just want to fork this logic
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "near-contract-standards" | |||
| version = "4.0.0-pre.8" | |||
| version = "4.0.1" | |||
11 tasks
|
Going to close this, since this change will come with #918 and cannot come in like this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
owner_by_idupdated from TreeMap to Unordered map due to #800.simulate_mass_minttest introduced.Please review if my version upgrade was correct.