introduce ed25519_verify #1007
Closed
introduce ed25519_verify #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasrodri
requested review from
ChaoticTempest,
itegulov and
miraclx
as code owners
blasrodri
commented
Feb 1, 2023
| @@ -61,7 +61,7 @@ impl MockedBlockchain { | |||
| let context = sdk_context_to_vm_context(context); | |||
| ext.fake_trie = storage; | |||
| ext.validators = validators.into_iter().map(|(k, v)| (k.parse().unwrap(), v)).collect(); | |||
| let memory = memory_opt.unwrap_or_else(|| Box::new(MockedMemory {})); | |||
| let memory = memory_opt.unwrap_or_else(|| Box::new(MockedMemory::default())); // TODO: find a better way to del with MockedMemory | |||
There was a problem hiding this comment.
been having issues with the memory, when running the tests. HELP!
|
Hey lads, been waiting on this feature, is there a known blocker or an eta for when one can expect this to be merged ? |
|
Closing in favor of #1010, with reviews already ongoing. Thanks @blasrodri. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After stabilizing feature
ed25519_verify, next step is to introduce it in the rust sdk.