feature: aliasing for functions with duplicate names

[muse254]

The changes introduced addresses #1084.
Concerned with aliasing colliding names in the generated abi using #[abi_alias(...)] as such:

trait T1{
   fn foo(&self);
}

trait T2 {
   fn foo(&self);
}

struct Contract;


impl T1 for Contract {
   fn foo(&self){
      log!("foo_one");
   }
}

impl T2 for Contract {
   #[abi_alias("foo_two")
   fn foo(&self){
      log!("foo_two");
   }
}

[muse254]

I would appreciate any help on the error https://github.com/near/near-sdk-rs/actions/runs/7931779144/job/21656768065?pr=1144

[frol]

@muse254 I believe it does not address the problem raised in #1084. They had a problem when there are two functions with exactly the same names implemented for the same struct (through impl trait for ...). The problem is that #[near_bindgen] generates an extern "C" fn, which does not use a fully-qualified (unambiguous) syntax, and as such contract.foo() raises a compilation error. Also, I find abi_alias naming a bit confusing as for me it sounds like it will only be renamed in the ABI schema, and not in the contract itself, and "alias" implies that it will be reachable by both original and the alias names (I am not sure if that was intended)

P.S. The CI error is fixed in the upstream now, so I merged the latest changes from there to your PR branch.

[muse254]

I'll look into understanding the problem and the repo some more and rework the solution. Thank you for taking your time to review ❤️

[frol]

This is taken over by #1186