-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: 1.79 fixes (replace macos-latest stable
with macos-latest 1.78
)
#1202
Conversation
I'm looking into this in another branch and locally, if I make progress - I will let you know. |
This is not reproducible locally on my mac. Could it be the cache? |
@ruseinov , what's the processor type of your machine? It might be some wicked bug of 1.79 affecting only |
I have an m2-pro, so that should have popped up. |
I have tried investigating this with |
I guess you have already talked to @frol. Perhaps we should pin the version to 1.78 as a temp fix, either via |
macos-latest stable
with macos-latest 1.78
)
@@ -18,12 +18,15 @@ pub enum BindgenArgType { | |||
/// A single argument of a function after it was processed by the bindgen. | |||
pub struct ArgInfo { | |||
/// Attributes not related to bindgen. | |||
#[allow(unused)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these really unused or is it a clippy bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as far as go-to-references have told me, these are unused. looks like the code was copied from elsewhere,
but only some of the fields are used in the context of near-sdk-macros
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
triple-checked these; they are only created inside of ::new
constructors, and not touched by other code thereafter. So, as far as tooling can tell, these are unused
…github/workflows/test.yml` Co-authored-by: Vlad Frolov <frolvlad@gmail.com>
this passes if
macos-latest
is temporarily commented out https://github.com/near/near-sdk-rs/actions/runs/9566693799 ;otherwise,
macos-latest
is having some serious trouble on 1.79