Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl clone for iter/values/keys of storage types #1224

Merged
merged 7 commits into from
Aug 5, 2024
Merged

Conversation

g4titanx
Copy link
Contributor

@g4titanx g4titanx commented Jul 31, 2024

issue no: #1121

@frol
Copy link
Collaborator

frol commented Jul 31, 2024

CI still fails, by the way

@frol
Copy link
Collaborator

frol commented Jul 31, 2024

@g4titanx Please also add the test from the original issue to demonstrate the cycle() now works as expected.

@frol
Copy link
Collaborator

frol commented Aug 4, 2024

@g4titanx Could you, please, address the CI errors?

@g4titanx
Copy link
Contributor Author

g4titanx commented Aug 5, 2024

@g4titanx Could you, please, address the CI errors?

done, checks successful

Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and sweet!

@g4titanx Thank you for contributing to NEAR ecosystem!

@race-of-sloths score 3

@race-of-sloths
Copy link

@frol Thank you for calling!

@g4titanx Thank you for the contribution! Join Race of Sloths by simply mentioning me in your comment/PRs description and start collecting Sloth Points through contributions to open source projects.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@frol frol merged commit 9c15030 into near:master Aug 5, 2024
29 checks passed
@frol frol mentioned this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants