Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates near-* dependencies to 0.24.0 #1237

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Conversation

akorchyn
Copy link
Collaborator

@akorchyn akorchyn commented Aug 9, 2024

near-workspaces should be updated later. It's not a blocker as it's used in tests and it has cyclic dependency :)

cc @race-of-sloths

@akorchyn akorchyn marked this pull request as ready for review August 9, 2024 15:34
@akorchyn akorchyn requested a review from frol as a code owner August 9, 2024 15:34
@race-of-sloths
Copy link

race-of-sloths commented Aug 9, 2024

@akorchyn Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
We are launching a survey "Who is faster? You vs SpaceX"

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 5
@ruseinov 5

Your contribution is much appreciated with a final score of 5!
You have received 50 Sloth points for this contribution

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@dj8yfo
Copy link
Collaborator

dj8yfo commented Aug 12, 2024

@ruseinov insert_and_remove fails in storage_performance_tests.rs (a few reruns). What's a possible fix?

@ruseinov
Copy link
Collaborator

@ruseinov insert_and_remove fails in storage_performance_tests.rs (a few reruns). What's a possible fix?

Run locally and adjust the number if iterations for each collection.
In this case it consumes less gas than expected, it's not a bad thing. There was enough slack given to avoid those errors, but if there is a significant deviation - this will fail with an error.

@akorchyn
Copy link
Collaborator Author

I have updated amount of iterations, let's see, but anyways, we should a bit on hold this PR, as windows is part of testing, and it's broken now in 0.24 release :(

See details: https://near.zulipchat.com/#narrow/stream/295558-core/topic/windows.20compilation.20issue.20on.202.2E0.2E0/near/459477738

@ruseinov
Copy link
Collaborator

ruseinov commented Aug 12, 2024

I have updated amount of iterations, let's see, but anyways, we should a bit on hold this PR, as windows is part of testing, and it's broken now in 0.24 release :(

See details: https://near.zulipchat.com/#narrow/stream/295558-core/topic/windows.20compilation.20issue.20on.202.2E0.2E0/near/459477738

There is another collection that is failing now. I would suggest running those tests locally first an making sure they are well above the lower range on your machine. Then it's likely to pass in the CI.
The problem is that the gas amounts are slightly different depending on the build environment.

Yeah, it seems broken indeed.

@akorchyn
Copy link
Collaborator Author

Sure, I have adjusted all 5 tests to be in somewhere [98-103] range to give extra flex. A lot of them was in 90ish

Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we get a free 5-10% improvement in runtime performance by just upgrading the dependencies? Nice

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@66918f3). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1237   +/-   ##
=========================================
  Coverage          ?   79.61%           
=========================================
  Files             ?      102           
  Lines             ?    14606           
  Branches          ?        0           
=========================================
  Hits              ?    11628           
  Misses            ?     2978           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruseinov
Copy link
Collaborator

Did we get a free 5-10% improvement in runtime performance by just upgrading the dependencies? Nice

I have a suspicion that this has to do specifically with near-workspaces update as that's what is currently used for our integration testing. Either way it's nice!

@akorchyn
Copy link
Collaborator Author

akorchyn commented Aug 13, 2024

+1, but also I think that you might have improved performance in other PRs, but it was still in range and this PR just reached the threshold

@akorchyn
Copy link
Collaborator Author

E.g. PR like this one: #1220 definitely improved some gas performance

@akorchyn akorchyn changed the title chore: updated near-* to 0.24.0 chore: updates near-* dependencies to 0.24.0 Aug 13, 2024
@akorchyn akorchyn merged commit dffe4b9 into near:master Aug 13, 2024
30 checks passed
@race-of-sloths
Copy link

🥁 Score it!

@frol @ruseinov, please score the PR with @race-of-sloths score [1/2/3/5/8/13]. The contributor deserves it.
If no scoring is provided within 24 hours, this PR will be scored as 2 🦥

@frol frol mentioned this pull request Aug 13, 2024
@frol
Copy link
Collaborator

frol commented Aug 13, 2024

@race-of-sloths score 5

1 similar comment
@ruseinov
Copy link
Collaborator

@race-of-sloths score 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants