-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updates near-* dependencies to 0.24.0 #1237
Conversation
@akorchyn Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 5! What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
@ruseinov |
Run locally and adjust the number if iterations for each collection. |
I have updated amount of iterations, let's see, but anyways, we should a bit on hold this PR, as windows is part of testing, and it's broken now in 0.24 release :( |
There is another collection that is failing now. I would suggest running those tests locally first an making sure they are well above the lower range on your machine. Then it's likely to pass in the CI. Yeah, it seems broken indeed. |
Sure, I have adjusted all 5 tests to be in somewhere [98-103] range to give extra flex. A lot of them was in 90ish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we get a free 5-10% improvement in runtime performance by just upgrading the dependencies? Nice
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1237 +/- ##
=========================================
Coverage ? 79.61%
=========================================
Files ? 102
Lines ? 14606
Branches ? 0
=========================================
Hits ? 11628
Misses ? 2978
Partials ? 0 ☔ View full report in Codecov by Sentry. |
I have a suspicion that this has to do specifically with |
+1, but also I think that you might have improved performance in other PRs, but it was still in range and this PR just reached the threshold |
E.g. PR like this one: #1220 definitely improved some gas performance |
@race-of-sloths score 5 |
1 similar comment
@race-of-sloths score 5 |
near-workspaces should be updated later. It's not a blocker as it's used in tests and it has cyclic dependency :)
cc @race-of-sloths