fix: simulator doesn't fail with long chains #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
requested review from
chadoh,
evgenykuzyakov and
mikedotexe
as code owners
The core issue is that Block is essentially a linked list, so: * dropping it may SO * cloning it is linear and may SO Fix the drop manually and optimize the clone to be O(1) closes #379
|
Awesome+1! |
ailisp
approved these changes
Apr 28, 2021
| @@ -87,7 +87,7 @@ impl GenesisConfig { | |||
|
|
|||
| #[derive(Debug, Default, Clone)] | |||
| pub struct Block { | |||
| prev_block: Option<Box<Block>>, | |||
| prev_block: Option<Arc<Block>>, | |||
There was a problem hiding this comment.
Do we actually need Arc here? Would Rc suffice?
There was a problem hiding this comment.
Good question, I haven't actually thought about this. I'd say that:
- both would probably work
- it doesn't really matter which one we pick here (like, this worked before by just copying the whole thing)
- Arc seems to be a better default choice, as that preserves Sync-ness of the Block
There was a problem hiding this comment.
I wonder if we use Box recursively somewhere in nearcore as well
There was a problem hiding this comment.
@evgenykuzyakov nerdsniped! Here's the list of recursive types from nearcore:
rust-lang/rust-analyzer@ffd9283
Nothing there seems problematic.
Though, the tool is rather simplistic, it might've misssed some
skyward-dev
approved these changes
Apr 29, 2021
evgenykuzyakov
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core issue is that Block is essentially a linked list, so:
Fix the drop manually and optimize the clone to be O(1)
closes #379