feat: Initialize blockchain interface by default #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-90
to
-93
| use near_sdk::MockedBlockchain; | ||
| use near_sdk::{testing_env, VMContext}; | ||
|
|
||
| fn get_context(input: Vec<u8>, is_view: bool) -> VMContext { |
There was a problem hiding this comment.
So by having a default mocked blockchain, we don't have to go thru the shenanigans of setting up the context here and also explicitly using testing_env! right? This is pretty nice for setting up new tests 👍.
There was a problem hiding this comment.
yeah, you still need it if you need to configure anything, but if not this saves some boilerplate.
Ideally, I think it might be nice to just be able to modify the context in place rather than replacing it, but there are a lot of connected pieces rn.
mikedotexe
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes based on #417 because it removes
BLOCKCHAIN_INTERFACEfrom non-wasm32 environments, and this default only makes sense outside anyway.One part of #440, going to split up changes because other ideas I have are more opinionated/breaking.
This change is completely backwards compatible from #417 and I changed only some of the examples to show this.
Ideally, in the future, it would be possible to modify the context of the mocked blockchain in place instead of still rigidly constructing a new context and replacing the current one, which will come with more QOL improvements.