refactor!: replace external vm interface and receipts with local ones #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Jul 19, 2021
…-rs into austin/replace_ext_logic
austinabell
changed the title
matklad
reviewed
Jul 21, 2021
| @@ -0,0 +1,52 @@ | |||
| use crate::{AccountId, Balance, Gas, PublicKey}; | |||
| // use near_vm_logic::mocks::mock_external::Action as VmAction; | |||
…-rs into austin/replace_ext_logic
austinabell
requested review from
ChaoticTempest,
evgenykuzyakov and
mikedotexe
as code owners
ChaoticTempest
approved these changes
Jul 21, 2021
mikedotexe
reviewed
Jul 22, 2021
| use crate::{AccountId, Balance, Gas, PublicKey}; | ||
|
|
||
| #[derive(Clone, Debug)] | ||
| pub struct Receipt { |
There was a problem hiding this comment.
This will be quite helpful, thanks
mikedotexe
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes need for near/nearcore#4101 through just creating
SdkExternalto satisfy the interface done by vm_logic before.Built on #451 as it's a cleaner change to not have to deal with conflicts so leaving in draft for now
This exposes Receipts and the sub fields to be able to be used in tests