remove external private modules #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 10, 2021 08:50
ghost
requested review from
austinabell,
ChaoticTempest,
evgenykuzyakov and
mikedotexe
as code owners
added 2 commits
October 10, 2021 10:25
austinabell
approved these changes
Oct 10, 2021
ghost
changed the title
|
Will add this in the next 4.0 pre-release. Would it be beneficial if I release this ASAP or is it fine to wait a few days? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your
near-sdk-macrosdepends on private modules issyn.It's not good for code to depend on private modules in other packages.
This was fixed by
syndtolnay/syn@957840ePlease merge this. Causing conflicts when using the fixed
synversions.