fix: code generation for mut self methods #616
Conversation
austinabell
requested review from
ChaoticTempest,
evgenykuzyakov and
mikedotexe
as code owners
| @@ -105,7 +105,7 @@ impl AttrSigInfo { | |||
|
|
|||
| if let Some(ref receiver) = receiver { | |||
| if matches!(method_type, MethodType::Regular) { | |||
| if receiver.mutability.is_none() { | |||
| if receiver.mutability.is_none() || receiver.reference.is_none() { | |||
There was a problem hiding this comment.
I'm not sure why we can't just have
if receiver.reference.is_none() {but compilation_tests/payable_view.rs successfully compiles even though its expected not to.
This conditional should just only be checking for mut self and self signatures, where checking for mutability shouldn't matter at all. But somehow also related to pay(&self) signature in payable_vew.rs? Maybe there's some sort of complexity somewhere we're not noticing or I'm probably missing something here.
There was a problem hiding this comment.
Nah this is intentional. This was the point of the PR that mut self was treated as mutating state and tries to write the data after. If you check only for reference, you don't differentiate between mutable and immutable references
There was a problem hiding this comment.
Ahh, so I was confused what this whole if block was checking. Thought it was for self and mut self but was actually for the reference versions &self
Closes #615
Probably rare someone would want to modify this structure in place for a view method, which is probably how this wasn't hit before, but good to have this functional