Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup TODOs and deprecate bad functions #671

Merged
merged 4 commits into from
Dec 16, 2021

Conversation

austinabell
Copy link
Contributor

Cleanup getting ready for stable 4.0

  • Adds missing pattern for testing_env! macro
  • Deprecate setup functions that are either not needed or a foot gun because of side effects

ref #494

Copy link
Member

@ChaoticTempest ChaoticTempest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

error[E0133]: call to unsafe function is unsafe and requires unsafe function or block
--
--> /host/near-sdk/src/environment/env.rs:494:5
\|
494 \|     core::arch::wasm32::unreachable();
\|     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function
\|
= note: consult the function's documentation for information on how to avoid undefined behavior

So it looks like the docker image still needs to get updated

@austinabell austinabell merged commit f34b9e8 into master Dec 16, 2021
@austinabell austinabell deleted the austin/todo_cleanup branch December 16, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants