refactor: make lockable-ft example use Result-based error handling
#750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| &mut self, | ||
| escrow_account_id: AccountId, | ||
| allowance: String, | ||
| ) -> Result<(), &'static str> { | ||
| let allowance = u128::from_str(&allowance).expect("Failed to parse allowance"); |
There was a problem hiding this comment.
probably preferable if we switch these .expect calls over to early returning an error since our error type is a str anyways, but not a big deal if we leave it as is
ChaoticTempest
approved these changes
Mar 11, 2022
austinabell
reviewed
Mar 14, 2022
| } | ||
|
|
||
| /// Locks an additional `lock_amount` to the caller of the function (`predecessor_id`) from | ||
| /// the `owner_id`. | ||
| /// Requirements: | ||
| /// * The (`predecessor_id`) should have enough allowance or be the owner. | ||
| /// * The owner should have enough unlocked balance. | ||
| pub fn lock(&mut self, owner_id: AccountId, lock_amount: String) { | ||
| #[return_result] | ||
| pub fn lock(&mut self, owner_id: AccountId, lock_amount: String) -> Result<(), &'static str> { | ||
| let lock_amount = u128::from_str(&lock_amount).expect("Failed to parse allow lock_amount"); |
There was a problem hiding this comment.
If switching over to this pattern, probably worth switching this expect to mapping the error and using ?
| &mut self, | ||
| owner_id: AccountId, | ||
| unlock_amount: String, | ||
| ) -> Result<(), &'static str> { | ||
| let unlock_amount = | ||
| u128::from_str(&unlock_amount).expect("Failed to parse allow unlock_amount"); |
There was a problem hiding this comment.
same here, and a few other places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #745 (review)
Also covered this example with workspaces-powered tests since that is the only way to test the new error handling behavior.