Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ext_contract macro to FungibleTokenMetadataProvider trait #836

Conversation

ebramanti
Copy link
Contributor

Currently, users building smart contracts can use ext_ft_core to make cross-contract calls to Fungible token methods enumerated in NEP-141. However, to make a call to the ft_metadata method, they have to define their own trait in their smart contract because FungibleTokenMetadataProvider does not have a ext_contract macro. This PR adds the ext_contract macro to the FungibleTokenMetadataProvider trait so that users do not have to copy/paste this trait into their code.

Enables users to import FungibleTokenMetadataProvider for cross-contract calls
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very valid! Thanks for the contribution :)

@austinabell austinabell merged commit dcab3ed into near:master Jun 8, 2022
@ebramanti ebramanti deleted the chore/add-ext-contract-to-ft-metadata-provider branch June 9, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants