Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove store usage related to creating account from wallet.js #2379

Closed
marcinbodnar opened this issue Jan 17, 2022 · 0 comments · Fixed by #2380
Closed

Remove store usage related to creating account from wallet.js #2379

marcinbodnar opened this issue Jan 17, 2022 · 0 comments · Fixed by #2380
Assignees
@marcinbodnar

Comments

@marcinbodnar
Copy link
Contributor

Regarding the circular reference that is causing problems with Jest testing, we want to remove all imports of the store and use thunks instead.

This PR is addressing this issue regarding wallet.js .
@marcinbodnar marcinbodnar self-assigned this Jan 17, 2022
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refector: remove unused method (#2379)
b1c60c9
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: create addLocalKeyAndFinishSetup thunk (#2379)
64f6792
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: create createIdentityFundedAccount thunk (#2379)
66fb69c
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: create createNewAccount thunk (#2379)
591cd24
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: create createAccountFromImplicit thunk (#2379)
a99b510
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: create createAccountWithSeedPhrase thunk (#2379)
95f60bf
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: create createNewAccountWithCurrentActiveAccount thunk (#2379)
d361d7e
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: cleanup (#2379)
f59979c
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: use createNewAccount thunk instead of action (#2379)
771a652
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: remove unused action (#2379)
fbe27a4
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: use createNewAccount thunk instead of action (#2379)
94d4ce9
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: use new createAccountFromImplicit thunk instead of action (#…
e922658 
…2379)
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: use new createAccountWithSeedPhrase thunk instead of action (…
a6c5ba3 
…#2379)
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: use new addLocalKeyAndFinishSetup thunk instead of method (#…
d067b91 
…2379)
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: use new addLocalKeyAndFinishSetup thunk instead of method (#…
c85ac95 
…2379)
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: use new createNewAccountWithCurrentActiveAccount thunk inst…
a80bd97 
…ead of method (#2379)
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: use new createIdentityFundedAccount thunk instead of method (…
a24fd9a 
…#2379)
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: remove unused actions (#2379)
3d6b22c
marcinbodnar added a commit that referenced this issue Jan 18, 2022
@marcinbodnar
refactor: remove unused methods (#2379)
f576606
@marcinbodnar marcinbodnar changed the title Remove store usage in wallet.js Remove store usage related to creating account in wallet.js Jan 19, 2022
@marcinbodnar marcinbodnar changed the title Remove store usage related to creating account in wallet.js Remove store usage related to creating account from wallet.js Jan 19, 2022
@marcinbodnar marcinbodnar linked a pull request Jan 19, 2022 that will close this issue
Remove store usage related to creating account from wallet.js #2380
Merged
marcinbodnar added a commit that referenced this issue Jan 25, 2022
@marcinbodnar
refector: remove unused method (#2379)
0d2b613
marcinbodnar added a commit that referenced this issue Jan 25, 2022
@marcinbodnar
refactor: create addLocalKeyAndFinishSetup thunk (#2379)
066ddd3
marcinbodnar added a commit that referenced this issue Jan 25, 2022
@marcinbodnar
refactor: create createIdentityFundedAccount thunk (#2379)
e6216a4
marcinbodnar added a commit that referenced this issue Jan 25, 2022
@marcinbodnar
refactor: create createNewAccount thunk (#2379)
67dfa0e
marcinbodnar added a commit that referenced this issue Jan 25, 2022
@marcinbodnar
refactor: remove unused actions (#2379)
68af4d5
marcinbodnar added a commit that referenced this issue Jan 25, 2022
@marcinbodnar
refactor: remove unused methods (#2379)
2cf472e
marcinbodnar added a commit that referenced this issue Jan 27, 2022
@marcinbodnar
fix: unwrap dispatch error (#2379)
192cc37
marcinbodnar added a commit that referenced this issue Jan 27, 2022
@marcinbodnar
fix: unwrap dispatch error (#2379)
47b333d
marcinbodnar added a commit that referenced this issue Jan 27, 2022
@marcinbodnar
fix: unwrap dispatch error (#2379)
69b1e68
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refector: remove unused method (#2379)
fc93de9
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: create addLocalKeyAndFinishSetup thunk (#2379)
01e3c30
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: create createIdentityFundedAccount thunk (#2379)
689e0a0
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: create createNewAccount thunk (#2379)
68971c2
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: create createAccountFromImplicit thunk (#2379)
8a20e73
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: create createAccountWithSeedPhrase thunk (#2379)
705895d
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: create createNewAccountWithCurrentActiveAccount thunk (#2379)
fcadfaf
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: cleanup (#2379)
9f58721
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: use createNewAccount thunk instead of action (#2379)
450fe88
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: remove unused action (#2379)
47447d7
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: use createNewAccount thunk instead of action (#2379)
6fe9a3c
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: use new createAccountFromImplicit thunk instead of action (#…
9b791c0 
…2379)
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: use new createAccountWithSeedPhrase thunk instead of action (…
332733a 
…#2379)
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: use new addLocalKeyAndFinishSetup thunk instead of method (#…
5767ef4 
…2379)
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: use new addLocalKeyAndFinishSetup thunk instead of method (#…
cfacdd8 
…2379)
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: use new createNewAccountWithCurrentActiveAccount thunk inst…
7a79daf 
…ead of method (#2379)
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: use new createIdentityFundedAccount thunk instead of method (…
9e05184 
…#2379)
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: remove unused actions (#2379)
34367ee
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
refactor: remove unused methods (#2379)
201252f
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
fix: unwrap dispatch error (#2379)
da11d17
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
fix: unwrap dispatch error (#2379)
e39b5a4
esaminu pushed a commit that referenced this issue Feb 16, 2022
@marcinbodnar @esaminu
fix: unwrap dispatch error (#2379)
a64b760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcinbodnar marcinbodnar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove store usage related to creating account from wallet.js near/near-wallet
1 participant
@marcinbodnar