Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stake Farming Feature on Wallet #2383

Closed
pretfood opened this issue Jan 18, 2022 · 4 comments · Fixed by #2384
Closed

Stake Farming Feature on Wallet #2383

pretfood opened this issue Jan 18, 2022 · 4 comments · Fixed by #2384
Assignees
Labels
📈 Enhancement Nice to have features & optimizations Priority 3 Not Urgent 🛠 UX / UI Requires discovery and/or deliverables from Product Design

Comments

@pretfood
Copy link

Problem

On stake farming contracts, users cannot see rewards in their wallet. At present, only $NEAR rewards are visible on the wallet. In new stake farming contracts, rewards are returned in $AURORA, but these are not visible.

Expected Behavior

Staking rewards should be displayed in more than one currency.

Steps to reproduce

  1. Stake $NEAR tokens in aurora.pool.near
  2. Watch how the rewards number never moves beyond 0, despite claimed APY of 29%.
@stefanopepe stefanopepe linked a pull request Jan 19, 2022 that will close this issue
@stefanopepe
Copy link
Contributor

There's work in progress, but no commitment on the timing for the release, as it needs a final review on the UX side.

@stefanopepe stefanopepe added Priority 3 Not Urgent 📈 Enhancement Nice to have features & optimizations labels Jan 19, 2022
@stefanopepe stefanopepe added the 🛠 UX / UI Requires discovery and/or deliverables from Product Design label Jan 19, 2022
@esaminu esaminu reopened this Jan 20, 2022
@esaminu
Copy link
Contributor

esaminu commented Jan 20, 2022

@corwinharrell Would appreciate some design input on this. We created a first iteration on #2384 that impacts the main staking page to display NEAR token icons and the validator page to display NEAR balance with icon and other tokens if any e.g. the aurora validator:

@heycorwin
Copy link
Contributor

heycorwin commented Jan 20, 2022

Screen Shot 2022-01-20 at 6 47 43 PM

Until we have a new UI, I think it is actually clearest to group the rewards under a single section and label. This way, it simply becomes a list of Rewards earned, and the icon and symbol denote the particular token, without the need for separate labels and sections.

I think the only remaining necessary change then would be to change the tooltip icon to read something like:

Rewards earned but not withdrawn. NEAR token rewards are compounding and are automatically re-staked.

@esaminu
Copy link
Contributor

esaminu commented Jan 21, 2022

UI and copy for v1 (token rewards display) updated in #2388

@esaminu esaminu closed this as completed Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Enhancement Nice to have features & optimizations Priority 3 Not Urgent 🛠 UX / UI Requires discovery and/or deliverables from Product Design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants