Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable import of zero balance Ledger account (testnet) #2679

Merged
merged 3 commits into from
May 17, 2022

Conversation

Patrick1904
Copy link
Contributor

@Patrick1904 Patrick1904 commented May 16, 2022

This enables a user to import a non-existent Ledger implicit account into the wallet (on testnet)

To test:

  1. Go to https://my-near-wallet-pr-2679.onrender.com/sign-in-ledger
  2. Change Ledger HD path to any path without an existing account
  3. Try importing the account
  4. Click 'Import anyway' when prompted
  5. Confirm key on Ledger device
  6. Observe that the Ledger account has been imported with given key

@render
Copy link

render bot commented May 16, 2022

@netlify
Copy link

netlify bot commented May 16, 2022

Deploy Preview for glittering-pavlova-0e9247 ready!

Name Link
🔨 Latest commit 2033667
🔍 Latest deploy log https://app.netlify.com/sites/glittering-pavlova-0e9247/deploys/628409b7c399c9000a96d394
😎 Deploy Preview https://deploy-preview-2679--glittering-pavlova-0e9247.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@render
Copy link

render bot commented May 16, 2022

@Patrick1904 Patrick1904 requested a review from esaminu May 16, 2022 23:48
@Patrick1904 Patrick1904 changed the title feat: Enable import of zero balance Ledger account feat: Enable import of zero balance Ledger account (testnet) May 16, 2022
@Patrick1904 Patrick1904 requested a review from morgsmccauley May 17, 2022 17:40
@Patrick1904 Patrick1904 marked this pull request as ready for review May 17, 2022 17:49
Copy link
Contributor

@morgsmccauley morgsmccauley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small Qs :)

@Patrick1904 Patrick1904 requested a review from morgsmccauley May 17, 2022 20:49
Copy link
Contributor

@morgsmccauley morgsmccauley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Patrick1904 Patrick1904 merged commit b8b8577 into master May 17, 2022
@Patrick1904 Patrick1904 deleted the zero-balance-ledger branch May 17, 2022 21:14
@andy-haynes andy-haynes mentioned this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants