-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable import of zero balance Ledger account (testnet) #2679
Conversation
Your Render PR Server URL is https://my-near-wallet-pr-2679.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ca1e4av9re0koq0htjgg. |
✅ Deploy Preview for glittering-pavlova-0e9247 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Your Render PR Server URL is https://near-wallet-pr-2679.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ca1e4c79re0koq0htk0g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small Qs :)
packages/frontend/src/components/accounts/CouldNotFindAccountModalWrapper.js
Show resolved
Hide resolved
packages/frontend/src/components/accounts/ledger/SignInLedgerWrapper.js
Outdated
Show resolved
Hide resolved
packages/frontend/src/components/accounts/CouldNotFindAccountModalWrapper.js
Show resolved
Hide resolved
packages/frontend/src/components/accounts/CouldNotFindAccountModalWrapper.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This enables a user to import a non-existent Ledger implicit account into the wallet (on testnet)
To test:
https://my-near-wallet-pr-2679.onrender.com/sign-in-ledger