Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lifetime in transact_async hard to use #248

Closed
austinabell opened this issue Dec 1, 2022 · 1 comment
Closed

Lifetime in transact_async hard to use #248

austinabell opened this issue Dec 1, 2022 · 1 comment

Comments

@austinabell
Copy link
Contributor

The lifetime referencing the client to poll here is quite restrictive when trying to await an async transaction in a separate task/thread. It would be ideal if the reference instead was an Arc to make it threadsafe, since the overhead doesn't matter in this context.
DavidM-D added a commit that referenced this issue Dec 2, 2022
@DavidM-D
Removed the lifetime in transact_async
31da88f 
Addresses #248

There are probably further improvements I could make to the API of
workspace now that Client has a clone instance, but I wanted to start
with a PR with a small footprint and get feedback.
@DavidM-D DavidM-D mentioned this issue Dec 2, 2022
Merged
@ChaoticTempest
Copy link
Member

Fixed with #249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChaoticTempest @austinabell