Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure sandbox #251

Merged
merged 5 commits into from
Dec 13, 2022
Merged

chore: configure sandbox #251

merged 5 commits into from
Dec 13, 2022

Conversation

ChaoticTempest
Copy link
Member

Separated out the logic purely from #241. This allows configuring config.json so that sandbox can do extra stuff on top of what mainnet/testnet does such as being able to patch large states which resolves #223

Copy link
Contributor

@DavidM-D DavidM-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good, but can we just replace most of this with this lib?

https://docs.rs/json-patch/0.2.7/json_patch/fn.merge.html

workspaces/src/network/mod.rs Show resolved Hide resolved
workspaces/src/network/config.rs Outdated Show resolved Hide resolved
workspaces/src/network/config.rs Show resolved Hide resolved
@ChaoticTempest
Copy link
Member Author

@DavidM-D didn't even know that library existed. At first was trying to find similar functionality inside serde_json

@DavidM-D
Copy link
Contributor

Not 100% sure we need to test json_patch, but your call and LGTM

@ChaoticTempest
Copy link
Member Author

I was keeping it just in case json_patch changes, but we're pinning the version anyways

@ChaoticTempest ChaoticTempest merged commit 8df17e5 into main Dec 13, 2022
@ChaoticTempest ChaoticTempest deleted the feat/conf-sandbox branch December 13, 2022 02:14
@frol frol mentioned this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix patch state not being able to patch for large amounts of data
3 participants