chore: Import some functions over from near_crypto for PublicKey #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miraclx
reviewed
Jan 20, 2023
miraclx
reviewed
Jan 21, 2023
| } | ||
|
|
||
| #[test] | ||
| fn test_pubkey_borsh_format_change() -> anyhow::Result<()> { |
There was a problem hiding this comment.
Hm. Struggling a bit to understand this test.
Is there a case where this would fail that's directly impacted by the struct here? Otherwise, it looks like a data test is all we're trying to do.
So this would be equivalent, no?
let mut data = vec![KeyType::ED25519 as u8];
data.extend(bs58::decode("6E8sCci9badyRkXb3JoRpBj5p8C6Tw41ELDZoiihKEtp").into_vec()?);
let new_key = PublicKey::try_from_slice(data.as_slice())?;
assert_eq!(
new_key.try_to_vec()?,
bs58::decode("16E8sCci9badyRkXb3JoRpBj5p8C6Tw41ELDZoiihKEtp").into_vec()?
);There was a problem hiding this comment.
hmm, now that you mention it, yeah it should be equivalent. I wonder why SDK did it like this in the first place
There was a problem hiding this comment.
oh it's because it had Vec<u8>.try_into() but I just got rid of it in favor of borsh
Co-authored-by: Miraculous Owonubi <omiraculous@gmail.com>
miraclx
approved these changes
Jan 21, 2023
| } | ||
|
|
||
| #[test] | ||
| fn test_pubkey_borsh_format_change() -> anyhow::Result<()> { |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds a couple convenience methods over from
near_cryptocrate. This was originally requested with justHashimpl in #263, but decided to import a couple more functions as they are convenient to have if people are managing public keys with workspaces