Patch feat/expose expt rpc apis #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…expose-expt-rpc-apis
|
Reviews addressed |
ghost
marked this pull request as ready for review
|
@frol This is ready to be reviewed. |
…ev/workspaces-rs into patch-feat/expose-expt-rpc-apis
examples/src/changes.rs
Outdated
Comment on lines
12
to
18
| let outcome = contract | ||
| _ = contract | ||
| .call("set_status") | ||
| .args_json(json!({ | ||
| "message": "hello_world", | ||
| })) | ||
| .transact() | ||
| .await?; |
There was a problem hiding this comment.
ideally should be using the result of the transaction. Best to add an into_result()? at the end to show best practices
examples/src/changes_in_block.rs
Outdated
Comment on lines
12
to
17
| let outcome = contract | ||
| _ = contract | ||
| .call("set_status") | ||
| .args_json(json!({ | ||
| "message": "hello_world", | ||
| })) | ||
| .transact() | ||
| .await?; |
workspaces/src/worker/impls.rs
Outdated
| ) -> Result<ProtocolConfigView> { | ||
| self.client().protocol_config(block_reference).await | ||
| } | ||
| pub async fn receipt(&self, ids: &[CryptoHash]) -> Result<ReceiptView> { |
There was a problem hiding this comment.
why is there a list of IDs passed when only the last one gets used via ids.last()?
examples/src/changes.rs
Outdated
| StateChangesRequestView::ContractCodeChanges { | ||
| account_ids: vec![contract.id().clone()], | ||
| } | ||
| let state_changes = StateChangesRequestView::ContractCodeChanges { |
There was a problem hiding this comment.
I don't like how we're utilizing *View structs to commit requests into the network. How about we create our own non-view ones, and that way we don't expose nearcore related dependencies too
added 3 commits
November 1, 2023 13:51
…ev/workspaces-rs into patch-feat/expose-expt-rpc-apis
ChaoticTempest
approved these changes
Nov 29, 2023
workspaces/src/worker/impls.rs
Outdated
| block_reference: BlockReference, | ||
| ) -> Result<RpcStateChangesInBlockByTypeResponse> { | ||
| self.client().changes_in_block(block_reference).await | ||
| pub fn changes(&self, account_ids: Vec<AccountId>) -> Query<'_, StateChanges> { |
There was a problem hiding this comment.
The inputs to this should just be a slice instead of a Vec as to make it more ergonomic for users to make use of
Suggested change
| pub fn changes(&self, account_ids: Vec<AccountId>) -> Query<'_, StateChanges> { | |
| pub fn changes(&self, account_ids: &[AccountId]) -> Query<'_, StateChanges> { |
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing code reviews for #285