chore: apply suggestions proposed by clippy

[aleksuss]

The motivation to propose these changes is to add the possibility of using this crate in projects which are checked with clippy with lints all and nursery.

[frol]

Thanks for bringing this up, but we need to understand motivation here. There are some obviously good changes, but there are also a lot of controversial ones, especially around promoting pub(crate) to pub. Please, provide more details in the comments

[aleksuss]

As described in the title, the changes have been proposed by the clippy linter. The point why clippy suggests making some methods and constants public is because they are defined in private modules, and these changes don't affect public API. And about main motivation. Now I can't bump version of this crate in my project because after bumping I get compiling errors:

note: future is not `Send` as this value is used across an await
   --> /Users/xxx/.cargo/registry/src/index.crates.io-6f17d22bba15001f/near-workspaces-0.8.0/src/rpc/patch.rs:289:81
    |
288 |                     AccountUpdate::FromCurrent(f) => {
    |                                                - has type `aurora_engine_types::Box<dyn std::ops::Fn(near_workspaces::types::account::AccountDetails) -> near_workspaces::types::account::AccountDetailsPatch>` which is not `Send`
289 |                         let account = self.worker.view_account(&self.account_id).await?;
    |                                                                                 ^^^^^^ await occurs here, with `f` maybe used later
290 |                         f(account)
291 |                     }
    |                     - `f` is later dropped here
    = note: `dyn std::ops::Fn(near_workspaces::types::account::AccountDetails) -> near_workspaces::types::account::AccountDetailsPatch` doesn't implement `std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> /Users/xxx/.cargo/registry/src/index.crates.io-6f17d22bba15001f/near-workspaces-0.8.0/src/rpc/patch.rs:289:81
    |
284 |             for update in self.account_updates {
    |                 ------ has type `near_workspaces::rpc::patch::AccountUpdate` which is not `Send`
...
289 |                         let account = self.worker.view_account(&self.account_id).await?;
    |                                                                                 ^^^^^^ await occurs here, with `update` maybe used later
...
293 |             }
    |             - `update` is later dropped here
    = note: `(dyn std::ops::Fn(near_workspaces::types::account::AccountDetails) -> near_workspaces::types::account::AccountDetailsPatch + 'static)` doesn't implement `std::marker::Send`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#future_not_send

[frol]

@aleksuss The compilation error due to the Send + Sync is real and indeed has to be addressed (please, also add a test).

I have disabled clippy::missing_const_for_fn and clippy::redundant_pub_crate lints as they produce false positives:

near-workspaces-rs/workspaces/src/lib.rs

Line 7 in b6f16a7

#![allow(clippy::missing_const_for_fn, clippy::redundant_pub_crate)]

Could you, please, revert the changes that added const fn and change visibility from pub(crate) to pub, and resolve merge conflicts?

[frol]

@aleksuss Does your code work if you compile it using your forked near-workspaces?

[aleksuss]

@frol yes, now it compiles without errors.

[frol]

@aleksuss near-workspaces 0.9 release is published! Thank you for contributing!