refactor: make patch state key Vec<u8> instead of String
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaoticTempest
approved these changes
Mar 1, 2022
austinabell
reviewed
Mar 1, 2022
Comment on lines
+123
to
124
| key: Vec<u8>, | ||
| value: Vec<u8>, |
There was a problem hiding this comment.
these should probably be slices to be consistent with the rest of the API, or is there a reason they are not @ChaoticTempest ?
There was a problem hiding this comment.
ahh, yeah best to keep them as slices. My bad, prematurely merged this one since it looked simple
There was a problem hiding this comment.
no worries, I can fix this real quick, I just went by the issue description
you want me to change both key and value to be &[u8], right?
There was a problem hiding this comment.
yup both should be slices
There was a problem hiding this comment.
was unrelated to this PR, just wanted to point out before opening an issue :)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51