Skip to content

Commit

Permalink
fix contributing process for merge queues (#9471)
Browse files Browse the repository at this point in the history
  • Loading branch information
Ekleog-NEAR authored Aug 31, 2023
1 parent d4642d0 commit 6762c06
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,12 @@ following steps when creating a PR:
need to pass before a PR can be merged.
2. When all the comments from the reviewer(s) have been addressed, they should
approve the PR allowing a PR to be merged.
3. An approved PR can be merged by adding the `S-automerge` label to it. The
label can be added by the author if they have the appropriate access or by a
reviewer otherwise. PR authors can also apply label immediately after filing a
PR: removing an additional round-trip after PR is approved.
3. An approved PR can be merged by clicking the "Merge when ready" button. The
button can be clicked by the author if they have the appropriate access, or by a
reviewer otherwise. PR authors can also click the button immediately after filing
a PR; removing an additional round-trip after the PR gets approved. The PR author
will be notified by email by github if the PR fails to land, once it has entered
the merge queue (ie. after it has passed PR CI and gotten an approving review).

## Code review process

Expand Down

0 comments on commit 6762c06

Please sign in to comment.