Skip to content

Commit

Permalink
fix: Correct the comment in db-migration.py (#11901)
Browse files Browse the repository at this point in the history
I thought the test failed because of 1.4 -> 2.0 migration, but it was
due to the [actual fix](#11724)
missing in both of the binaries. See
https://near.zulipchat.com/#narrow/stream/295302-general/topic/Database.20migration.20CI.20check.20is.20consistently.20failing/near/457086995
  • Loading branch information
tayfunelmas authored Aug 7, 2024
1 parent 6b5507a commit 9731d4d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pytest/tests/sanity/db_migration.py
100755 → 100644
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@
# Config to track all shards.
node_config = {
"tracked_shards": list(range(NUM_SHARDS)),
# We should have large enough GC window while the node running with the old binary (1.40), because we need to
# We should have large enough GC window while the node running with the old binary (2.0), because we need to
# bootstrap the congestion info from the genesis block and the genesis block should not be garbage collected.
# The new binary (2.0) has a mechanism to save the congestion info on disk to be resilient against GC of
# The new binary (2.1) has a mechanism to save the congestion info on disk to be resilient against GC of
# genesis block, however the old binary does not have this mechanism, thus we need to prevent GC to kick in
# before the node transitions to the new binary. Note that, after restarting the node with the new binary
# we can switch back to the usual GC window (see below).
# TODO: This change for GC can be removed when the old binary version becomes 2.0 in this test.
# TODO(#11902): This change for GC can be removed when the old binary version becomes 2.1 in this test.
"gc_num_epochs_to_keep": LARGE_GC_NUM_EPOCHS_TO_KEEP,
}

Expand Down

0 comments on commit 9731d4d

Please sign in to comment.