Skip to content

Commit

Permalink
fix(resharding) - fixing the resharding.py nayduck test (#10895)
Browse files Browse the repository at this point in the history
The resharding nayduck test is
[flaky](https://nayduck.near.org/#/test_history/593017). I believe that
is because every now and then taking the state snapshot takes a long
time and the test breaks before snapshot is ready for resharding.

I went all the way to the following line and it seems like most of the
slowness is there. It's down to rocksdb at this point and I don't feel
like debugging it further so I'm just going to increase the epoch length
to give the test enough time to take the snapshot and finish resharding.

https://github.com/near/nearcore/blob/d4d1b82f39a57932eff0a7a28c5745b72915f848/core/store/src/db/rocksdb/snapshot.rs#L98
  • Loading branch information
wacban authored Mar 28, 2024
1 parent d4d1b82 commit f98f3d9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pytest/tests/sanity/resharding.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
class ReshardingTest(ReshardingTestBase):

def setUp(self) -> None:
super().setUp(epoch_length=5)
super().setUp(epoch_length=20)

def test_resharding(self):
logger.info("The resharding test is starting.")
Expand Down

0 comments on commit f98f3d9

Please sign in to comment.