Fix broken nayduck tests after gas costs change #11031
Assignees
Comments
aborg-dev
changed the title
github-merge-queue bot
pushed a commit
that referenced
this issue
Apr 11, 2024
This is resolving one of the items from #11031 It is quite bizarre that this test is failing in the first place, as the change in the gas costs should be strictly beneficial to the users. Here is an example failure: https://nayduck.nearone.org/#/test/12357 @Ekleog-NEAR , any ideas?
Merged
github-merge-queue bot
pushed a commit
that referenced
this issue
Apr 15, 2024
Another instance of test broken by the gas cost increase. This completes #11031
|
I'll make another try to fix this as I have some spare cycles. CC @pugachAG |
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 2, 2024
There was a discrepancy between the costs used by the started nodes and the ones used by the fee_helper which was exposed when gas costs changed. There were a number of places where we select which RuntimeConfig to use: 1. Multiple NEAR nodes started in separate threads with random chain_id `test-chain-*` 2. `RuntimeNode` class 3. `fee_helper()` function 4. `TestEnv` builder All these places must use the same config for the gas calculations to match. I've decided to align all of these cases with the configs used in 1, which matches the current mainnet config. I think that's generally a good choice if available as we want the test environment to catch the problems that we will see on mainnet. There could be some tests that still rely on the values from `free` or `test` configs, but I argue that they should be using them explicitly. Fixes #11031.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After the gas costs change there are broken nayduck tests https://nayduck.nearone.org/#/run/38
Tasks
The text was updated successfully, but these errors were encountered: