Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable chunk producer shard assignment shuffling for mainnet launch #11190

Closed
tayfunelmas opened this issue Apr 30, 2024 · 1 comment
Closed
Assignees
Labels
A-stateless-validation Area: stateless validation

Comments

@tayfunelmas
Copy link
Contributor

tayfunelmas commented Apr 30, 2024

See related thread here.

We can keep shard shuffling for testing on forknet, but it is not critical and can be disabled for mainnet launch. It will help with keeping the network needs due to state sync under control as chunk producers will continue to track the same shard through different epochs.

Follow-up work to investigate and re-enable shard shuffling (likely with less frequent shuffling) will be tracked in #11201.

@tayfunelmas tayfunelmas added the A-stateless-validation Area: stateless validation label Apr 30, 2024
@tayfunelmas tayfunelmas self-assigned this May 1, 2024
github-merge-queue bot pushed a commit that referenced this issue May 9, 2024
Per #11190, move the shard-assignment shuffling feature for chunk
producers to nightly.

Also enable this feature for mocknet together with stateless validation
to exercise the state sync code path more often. Note that the guarding
for the feature in nightly/prod is different from mocknet, as we use
mocknet to exercise (stateless validation) features in between prod and
nightly.

After this change, shard shuffling will be activated in the following
cases:

1) In "nightly", it will be active by default, since we move the feature
among the set of nightly features and update the protocol version
accordingly (143).
2) In "mocknet", it will be active by default, as we enable it directly
when chain id == "mocknet".
3) In all other networks (including "mainnet", "testnet", and
"statelessnet"), it will be disabled by default and will only be enabled
(later) explicitly by moving the feature from nightly to stable protocol
version.

Compiling the binary with or without "statelessnet_protocol" will not
have any effect on the enablement of the feature (instead need to
compile with "nightly").
@tayfunelmas
Copy link
Contributor Author

Shard-assignment shuffling is now enabled in mocknet by default. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-stateless-validation Area: stateless validation
Projects
None yet
Development

No branches or pull requests

1 participant